Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: set the beginning of the new day(other than midnight) #60

Open
ghost opened this issue Feb 27, 2021 · 1 comment
Open

Feature: set the beginning of the new day(other than midnight) #60

ghost opened this issue Feb 27, 2021 · 1 comment

Comments

@ghost
Copy link

ghost commented Feb 27, 2021 •
edited by ghost
Loading

I am a night owl. I usually go to sleep around 2am..

It would be handy for me to be able to set that my date ends at 4am for example.

I am usually finishing my teapot at the evening and its not convenient to have to split it between days.
@manto89
Copy link

manto89 commented Jul 8, 2021

Hi,
I'm not an experience developer but I've worked on this issue and managed to find a solution.
This does include a change in the way data is saved, migrating from storing the intake on a daily record to saving individual records.
This allows the app to calculate "daily" intake based off wake up and sleeping times that are already saved in the settings.

The change in the way data is saved probably makes it incompatible with old versions, so I'm still thinking of a way to migrate data. If @z3r0c00l-2k can give some inputs maybe we can find a solution.

Meanwhile I'm pushing the commit on my fork and will make a PR with this and other issues I'm working on.
Let me know if you have any comments/issues

manto89 added a commit to manto89/AquaDroid that referenced this issue Jul 17, 2021
@manto89
z3r0c00l-2k#60
1262f85 
Added getIntake based off wakeup and sleeping time
Changed statistics values based off wakeup and sleeping time
Changed statistics to get only the last 7 days
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@manto89