This repository has been archived by the owner on Apr 1, 2020. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for custom commitlint configuration (i.e.
.commitlint.yml
,.commitlint.json
..etc) by proposing a new workflow inspired by code coverage services (e.g. CodeCov)Workflow
pending
)The script mainly runs
commitlint
CLI and passes--format=json
flag (thanks to @marionebl) (marionebl/commitlint#169) to get fully resolved configuration as JSON, then it uploads those configs in addition to some other info e.g pull request number, repository slug ..etc.Once uploaded, the app will dequeue the original request (currently we use commit SHA as an identifier) and restore its payload + the uploaded configs.
Now we do the actuall linting and report the final status back to GitHub
That the general idea, but feel free to ask questions if something isn't clear (I was sleepy when I wrote this description :p ).
Also, this still a work-in-progress and I'm open for suggestions and improvements!
Todos
/api/upload
)Resolves #1
/cc @caarlos0 @paulirish @marionebl and @ you for feedback