Merged
Conversation
Closed
zeenix
force-pushed
the
address-rework
branch
4 times, most recently
from
9341a0a to
7b00773
Compare
We're about to add submodules to this module.
zeenix
force-pushed
the
address-rework
branch
from
7b00773 to
e8cb200
Compare
More like a type hierarchy. `Address` is no longer an enum but a struct with hidden fields. This will allow us to add GUID information to address in a following commit withough duplicating it for each transport variant. AutolaunchScope code from Marc-Andre Lureau <marcandre.lureau@redhat.com>. Fixes z-galaxy#476.
We previously just ignored GUIDs in addresses. No more. We now parse it, if present and provide API to set a GUID on an `Address` instance.
instead of a string.
`Guid` now has a lifetime parameter, and `OwnedGuid` is a new type that's a wrapper around `Guid<'static>`. Internally, `Guid` is now a wrapper around `zvariant::Str` and is now a very similar type to other `zvariant::Str` wrapper types. This also turns `guid` argument of `connection::Builder::server` into a generic type.
If the client connection is constructed through an address with GUID in it, we should verify this GUID is the same as one received from the server during the handshake.
Add a new address::UnixPath variant for abstract sockets and replace our hack with the abstract unix socket support from std. Fixes z-galaxy#329.
zeenix
force-pushed
the
address-rework
branch
from
e8cb200 to
9518a1b
Compare
This satisfies a new clippy lint.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main changes:
Addressinto a separate type,Transport.Addressnow support GUIDs, rather than ignoring them.Guidtype.connection::Builderensure GUID is correct if the client connection is constructed through an address with GUID in it.Fixes #329, #476.