🐛 zx: Fix declaring proxies for writable properties#453
Merged
zeenix merged 1 commit intoz-galaxy:mainfrom Aug 23, 2023
Merged
Conversation
The `#[dbus_proxy(property)]` attribute needs to be present also at the `set_foo` function, otherwise the proxy will call a `SetFoo` method instead of `Set`ting the `Foo` property. Example: agama-project/agama#712
zeenix
reviewed
Aug 23, 2023
Contributor
zeenix
left a comment
zeenix
left a comment
There was a problem hiding this comment.
Super thanks for your contrbution and bonus points for adhering to our contribution guide! However, I've a question.
zeenix
approved these changes
Aug 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
#[dbus_proxy(property)]attribute needs to be present also at theset_foofunction, otherwise the proxy will call aSetFoomethod instead ofSetting theFooproperty.Example:
agama-project/agama#712