Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check_array added to fit in iforest and ecod #475

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

luismavs
Copy link

Hey,

For iforest models fitted with pandas Dataframes and then scored with decision_function() on pandas DataFrames, the following warning pops up:

xxxx/site-packages/sklearn/base.py:402: UserWarning: X has feature names, but IsolationForest was fitted without feature names

I have added very simple scikit learn utils check_array() to X in decision_function() to iforest (and ecod) models to suppress the warning.

All Submissions Basics:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you checked all Issues to tie the PR to a specific one?

All Submissions Cores:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?
  • Does your submission pass tests, including CircleCI, Travis CI, and AppVeyor?
  • Does your submission have appropriate code coverage? The cutoff threshold is 95% by Coversall.

@luismavs
Copy link
Author

luismavs commented Jun 27, 2023

hi, any update on this :) ?
thanks for the package!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant