Fix: Specifying custom style sheets with a relative path does not work #170
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting relative paths in markdown-pdf.styles currently (VS Code 1.41.0, Markdown PDF 1.4.1) does not work because the path will always be converted to a absolute path.
For example
styles/custom.css
will becomefiles:///styles/custom.css
This makes Markdown PDF fall back to the VS Code default styles.
The reason is, that
hrefUri.scheme === 'file'
is not only true for absolute file paths, but also for relative paths.This PR fixes this issue.