feat: add-exclude-commands - #903
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe Claude settings template broadens sandbox command exclusions to include Docker, Git, and SSH commands, while removing the previous filesystem write allowance. ChangesClaude sandbox configuration
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request updates the Claude settings template to add "git *" and "ssh *" to the list of excluded commands in the sandbox configuration. However, the changes also accidentally removed the entire "filesystem" configuration block, which would prevent Claude from writing to specified directories. The reviewer recommends restoring this block to avoid breaking tools and integrations.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| "~/wiki" | ||
| ] | ||
| } | ||
| "excludedCommands": ["docker *", "git *", "ssh *"] |
There was a problem hiding this comment.
The filesystem configuration block under sandbox was completely removed in this change. This appears to be an accidental deletion, as the PR title only mentions adding excluded commands. Removing this block will prevent Claude from writing to these directories, which may break various tools and integrations. Please restore the filesystem block.
"excludedCommands": ["docker *", "git *", "ssh *"],
"filesystem": {
"allowWrite": [
"~/.cache",
"~/.cargo/registry",
"~/.gradle",
"~/.local/lib",
"~/.local/share/uv",
"~/.m2",
"~/.mempalace",
"~/.memsearch",
"~/.npm",
"~/.yarn",
"~/Library/Caches",
"~/Library/Python",
"~/Library/pnpm",
"~/go/pkg",
"~/wiki"
]
}
Summary by CodeRabbit