refactor(okf): move okf skill to dot_agents, symlink from dot_claude - #902
Conversation
- Move okf skill source from private_dot_claude/skills/okf/ to private_dot_agents/skills/okf/ to match the pattern used by all other skills (agents is source, claude symlinks to it) - Add chezmoi symlink_okf in private_dot_claude/skills/ pointing to ../../.agents/skills/okf - Merge hooks/, dot_claude-plugin/ into private_dot_agents/okf/ - Remove mattpocock-skills@mattpocock plugin install — skills are installed selectively via npx skills in agent_plugins script - Remove mattpocock/skills marketplace entry from setup_claude script - Update okf-wiki-review.txt: more liberal capture criteria, improved wording (drop "daily", clearer synthesized summaries guidance) - SKILL.md: rename Modes → Task types, consolidate Done-when clauses, clean up description redundancy - Templates: realistic timestamp example, consistent list punctuation Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (16)
📝 WalkthroughWalkthroughThe changes conditionally register Claude Code, revise Matt Pocock skill installation, and migrate OKF functionality into an agents plugin with updated templates, lifecycle hooks, runbook instructions, and a Claude skill-directory symlink. ChangesAgent plugin configuration
OKF plugin migration
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Poem
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✅MegaLinter analysis: Success
Notices📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining See detailed reports in MegaLinter artifacts Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates agent plugins and the Open Knowledge Format (OKF) skill configuration. It introduces conditional logic to add claude-code to the agents list, cleans up old skill references, refactors the okf skill documentation and templates, and adds a new wiki review hook instruction file. Feedback on the changes recommends conditionally adding opencode to the agents list as well, and exiting the script early if no agents are found to prevent potential execution failures.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
1 participant
Summary
private_dot_claude/skills/okf/toprivate_dot_agents/skills/okf/— consistent with the pattern where.agents/skills/is the source and.claude/skills/symlinks to itsymlink_okfinprivate_dot_claude/skills/(chezmoi-managed symlink →../../.agents/skills/okf)mattpocock-skills@mattpocockplugin install — all mattpocock skills are already installed selectively vianpx skills addinrun_onchange_after_agent_plugins.sh.tmpl, so the plugin was loading 39 full SKILL.md files (~165k chars, ~41k tokens) into every session unnecessarilyokf-wiki-review.txtprompt: more liberal capture criteria (5 how/why/what bullets), cleaner wordingSKILL.md: renamesModes→Task types, removes inline "Done when" clauses (consolidated into existing "Before declaring done" section), removes redundant trigger wording from descriptionTest plan
chezmoi applydeploys~/.claude/skills/okfas symlink →../../.agents/skills/okf~/.agents/skills/okf/contains hooks/, dot_claude-plugin/, SKILL.md, SPEC.md, templates/~/wiki/chezmoi apply🤖 Generated with Claude Code
Summary by CodeRabbit
New Features
Improvements