Skip to content

Enable text-only mode for Llama4 when image limit is zero - #3

Merged
ywang96 merged 4 commits into
mainfrom
codex/add-text-only-mode-for-llama4
Aug 6, 2025
Merged

ywang96 merged 4 commits into
mainfrom
codex/add-text-only-mode-for-llama4

Conversation

@ywang96

@ywang96 ywang96 commented Aug 6, 2025

Copy link
Copy Markdown
Owner

Summary

  • skip vision model and projector when --limit-mm-per-prompt {"image":0} enabling text-only inference
  • treat model as non-multimodal when all modality limits are zero
  • add regression test for multimodal limit handling

Testing

  • pre-commit run --files vllm/model_executor/models/mllama4.py vllm/config.py tests/models/test_model_config.py (fails: pre-commit not installed, 403 when installing)
  • pytest tests/models/test_model_config.py (fails: torch missing, 403 when installing)

https://chatgpt.com/codex/tasks/task_e_6892ab31bc988324a0bb8b8d8ba11c87

@github-actions

github-actions Bot commented Aug 6, 2025

Copy link
Copy Markdown

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Roger Wang added 3 commits August 5, 2025 19:03
Signed-off-by: Roger Wang <hey@rogerw.me>
Signed-off-by: Roger Wang <hey@rogerw.me>
Signed-off-by: Roger Wang <hey@rogerw.me>
@ywang96
ywang96 merged commit 2f5da46 into main Aug 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant