Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix cpu vendor, swapping ecx/edx registers. #1052

Merged
merged 1 commit into from
May 4, 2023
Merged

fix cpu vendor, swapping ecx/edx registers. #1052

merged 1 commit into from
May 4, 2023

Conversation

devnexen
Copy link
Contributor

No description provided.

@devnexen
Copy link
Contributor Author

ping @yvt any chance you get the time to review it ? cheers 🙂

yvt
yvt requested changes May 1, 2023
View reviewed changes
Sources/Core/CpuID.cpp Outdated Show resolved Hide resolved
@yvt yvt merged commit f6f5108 into yvt:master May 4, 2023
@yvt
Copy link
Owner

yvt commented May 4, 2023

Thanks!

VierEck pushed a commit to VierEck/openspades that referenced this pull request Jun 23, 2023
@devnexen @siecvi
fix(core): swap ecx/edx registers when parsing CPUID (yvt#1052)
36008f2 
Fixes corrupted output when reading a CPU vendor name.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yvt yvt yvt requested changes

Assignees
No one assigned
Labels
PR: solve-bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devnexen @yvt