chore(deps): drop unused direct memmap2 dependency - #867
Closed
andig wants to merge 1 commit into
Closed
Conversation
Found in a ponytail-audit pass. `memmap2 = "0.9"` had zero use sites anywhere in rust/src, rust/crates, or rust/tests -- lean-ctx's own code never called it directly. Note: memmap2 remains in Cargo.lock as a transitive dependency of resvg -> fontconfig-parser (the optional SVG-rendering stack), so this doesn't shrink the compiled dependency tree or build time -- it only removes a dead, unused explicit version pin with no benefit (cargo already resolves the transitive constraint on its own). cargo build clean; full lib suite 7696 passed, 0 failed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found in a
/ponytail-auditpass (finding #9).memmap2 = "0.9"had zero use sites anywhere inrust/src,rust/crates, orrust/tests-- our own code never called it directly.Note:
memmap2remains inCargo.lockas a transitive dependency ofresvg->fontconfig-parser(the optional SVG-rendering stack), so this doesn't shrink the compiled dependency tree or build time -- it only removes a dead, unused explicit version pin (cargo already resolves the transitive constraint on its own without our redundant pin).Test plan
cargo build --lib -p lean-ctx-- cleancargo test --lib -p lean-ctx-- 7696 passed, 0 failed