Skip to content

Conversation

gregory-m
Copy link
Contributor

Decode function panics and hangs on some inputs.

@yvasiyarov
Copy link
Owner

@gregory-m unit tests failed. Can you, please, check your pull request again ?

@gregory-m
Copy link
Contributor Author

This is propose of this tests.

I found (using go-fuzz), some inputs that leading to crash.

I just put this strings into test.

Since I don't fixed anything tests will fail.

@yvasiyarov
Copy link
Owner

@gregory-m ok, got you. Anyway, thanks for this pull request. I will try to fix this test this weekend

@gregory-m
Copy link
Contributor Author

Thanks.

yvasiyarov pushed a commit that referenced this pull request Sep 7, 2015
@yvasiyarov yvasiyarov merged commit 5f8d7bc into yvasiyarov:master Sep 7, 2015
@yvasiyarov
Copy link
Owner

@gregory-m this case is fixed. Can you, possibly, provide me with corpus which you used ?

@gregory-m
Copy link
Contributor Author

@yvasiyarov
Copy link
Owner

@gregory-m thanks a lot!

kinosang pushed a commit to kinosang/php_serialize that referenced this pull request Nov 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants