Use Python-version agnostic helpers #974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamietanna
force-pushed
the
chore/python
branch
from
b8acb53 to
69af780
Compare
|
Amended with suggested fixes from yuzutech/kroki.io#80 |
jamietanna
changed the title
python utility commands are Python2
ggrossetie
reviewed
Nov 11, 2021
As it may not be the default `python` on an OS any more, we should make it possible to run against Python 2 and Python 3.
jamietanna
force-pushed
the
chore/python
branch
from
69af780 to
5b18e04
Compare
|
Sorry @Mogztter, good spot, that was a bad copy-paste! |
No worries, all good now, thanks 👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it may not be the default
pythonon an OS any more, we should makeit possible to run against Python 2 and Python 3.