-
-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resolves #698 update the description on Docker Hub #737
Conversation
Thanks @lind!
I don't think so but it's not a big deal since I can easily restore the description if something goes wrong.
You are 💯 right, we should use a dedicated file.
I agree but let's do that in a follow-up pull request.
I left a few suggestions but overall 👍🏻
It looks very good, thanks for taking care of this. |
Co-authored-by: Guillaume Grossetie <[email protected]>
Co-authored-by: Guillaume Grossetie <[email protected]>
Good idea. Let's get this to work for the main docker hub repository first. |
Co-authored-by: Guillaume Grossetie <[email protected]>
Co-authored-by: Guillaume Grossetie <[email protected]>
Co-authored-by: Guillaume Grossetie <[email protected]>
Co-authored-by: Guillaume Grossetie <[email protected]>
Co-authored-by: Guillaume Grossetie <[email protected]>
Co-authored-by: Guillaume Grossetie <[email protected]>
Co-authored-by: Guillaume Grossetie <[email protected]>
Co-authored-by: Guillaume Grossetie <[email protected]>
Thanks @lind, it's working great 🎉 |
A proposal for #698
I'm new to GitHub Actions but the action mentioned in the #698 should work. But I don't know if there is a way to test this without actually change the description in Dockerhub.
I''m not sure the README is the right file to use as the Dockerhub description since the README includes build information etc. not relevant to Dockerhub users and also there are a need for multiple Dockerhub descriptions, one for each docker image; bmpn, excalidraw...
Proposes one description file for each image in the same dir as the Dockerfile
/bpmn
,/excalidraw
...The proposed DOCKERHUB.md is just a copy and slight simplification of the description on Dockerhub today and needs some more work.
What do you think @Mogztter