KROKI_LISTEN option to start listening on an address #595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- KROKI_LISTEN has higher precedence than KROKI_PORT - Support `tcp://ip:port` value on KROKI_PORT (this value can be automatically set by the container runtime: k8s, Docker...) - Set KROKI_CONTAINER_SUPPORT environment variable on the Docker image to indicate that we are running in a container
Instead of relying on the default platform encoding (was UTF-8 on Linux).
ggrossetie
force-pushed
the
issue-576-container-support
branch
from
3ef5892 to
889f230
Compare
|
@jkroepke I would appreciate very much if you could review this pull request. If you are not familiar with Java, you can review the documentation. I want to make sure that the documentation is comprehensible! Thanks 😉 |
ggrossetie
commented
Feb 9, 2021
jkroepke
reviewed
Feb 9, 2021
Co-authored-by: Jan-Otto Kröpke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tcp://ip:portvalue on KROKI_PORT (this value can be automatically set by the container runtime: k8s, Docker...)resolves #576