Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Japanese text result is incorrect for png format #386

Closed
kaala opened this issue Sep 18, 2020 · 3 comments · Fixed by #579
Closed

Japanese text result is incorrect for png format #386

kaala opened this issue Sep 18, 2020 · 3 comments · Fixed by #579
Labels
🐞 bug Something isn't working

Comments

@kaala
Copy link

kaala commented Sep 18, 2020

original diagram

digraph D {
   b1 [label = "第一次川中島の戦い\n1553年"];
   b2 [label = "第二次川中島の戦い\n1555年"];
   b4 [label = "第三次川中島の戦い\n1557年"];
   b1 -> b2 -> b4;
}

compare PNG and SVG

https://kroki.io/graphviz/svg/eNpLyUwvSizIUHBRqOZSUFBIMlSIzklMSs1RsFVQer5mzZMdDc_WLHy6fe6THWufbt72uHHds45ljxtbYvIMTU2Nn-7cohRrDdZnhKZvVw9ufaZI-kzQ7evErc8cSZ-hgq4dyFYQaWLNVQsALpNctA==

https://kroki.io/graphviz/png/eNpLyUwvSizIUHBRqOZSUFBIMlSIzklMSs1RsFVQer5mzZMdDc_WLHy6fe6THWufbt72uHHds45ljxtbYvIMTU2Nn-7cohRrDdZnhKZvVw9ufaZI-kzQ7evErc8cSZ-hgq4dyFYQaWLNVQsALpNctA==

@ggrossetie ggrossetie added the 🐞 bug Something isn't working label Sep 18, 2020
@ggrossetie
Copy link
Member

Thanks for your report @kaala 👍
I can reproduce this issue, I will investigate!

ggrossetie added a commit to ggrossetie/kroki that referenced this issue Feb 2, 2021
ggrossetie added a commit to ggrossetie/kroki that referenced this issue Mar 19, 2021
@ggrossetie
Copy link
Member

@kaala Apparently, it was fixed in bd124e0

Could you please confirm that Japanese texts now render properly? Not sure if wqy-zenhei is good enough or if we should use Noto CJK instead?

@kaala
Copy link
Author

kaala commented Mar 22, 2021

Thank you, render result looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants