Skip to content

Commit

Permalink
Pass in a logger to get_metadata
Browse files Browse the repository at this point in the history
Without this, the log messages printed in
jupyter-server#1171
don't actually make it out. Whoops!

LoggingConfigurable inherits from HasTraits, and sets up
Logging appropriately so we can have a log passed through.
  • Loading branch information
yuvipanda committed Jan 14, 2023
1 parent 7e6daf7 commit 94e2cdc
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions jupyter_server/extension/manager.py
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ def load(self, serverapp):
return loader(serverapp)


class ExtensionPackage(HasTraits):
class ExtensionPackage(LoggingConfigurable):
"""An API for interfacing with a Jupyter Server extension package.
Usage:
Expand All @@ -172,7 +172,7 @@ def _validate_name(self, proposed):
name = proposed["value"]
self._extension_points = {}
try:
self._module, self._metadata = get_metadata(name)
self._module, self._metadata = get_metadata(name, self.log)
except ImportError as e:
msg = (
f"The module '{name}' could not be found ({e}). Are you "
Expand Down

0 comments on commit 94e2cdc

Please sign in to comment.