Fix codestyle check by removing concurrent newlines#2
Closed
CapChrisCap wants to merge 70 commits intoyuuteng:bloomberg-snowflakefrom
Closed
Fix codestyle check by removing concurrent newlines#2CapChrisCap wants to merge 70 commits intoyuuteng:bloomberg-snowflakefrom
CapChrisCap wants to merge 70 commits intoyuuteng:bloomberg-snowflakefrom
Conversation
…/SnowflakeClient.java Co-authored-by: Yuya Ebihara <ebyhry@gmail.com>
Co-authored-by: Yuya Ebihara <ebyhry@gmail.com>
Fully tested with Trino 406. Untested with 410.
Adding --add-opens to enable support for Apache Arrow via shared memory buffers.
TODO: testDataMappingSmokeTest: time and timestamp testSetColumnTypes: time and timestamp
This reverts commit 82f9eb3f3811e8d90a482f5359e98e7c729afa17.
Fully tested with Trino 406. Untested with 410.
…with Snowflake server. Disabled the testsetColumnTypes testing.
yuuteng
force-pushed
the
bloomberg-snowflake
branch
from
5520b5f to
b10a001
Compare
dprophet
added a commit
that referenced
this pull request
Dec 5, 2023
Feature/2551 add snowflake connector
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed the minor issue that was also reported on Slack: https://trinodb.slack.com/archives/C0305TQ05KL/p1693386128831189
Command example)
Current error
After removing the newlines, the error is resolved