Presenters: Fix for using destroyed view data

yuliskov · Jan 27, 2025 · 7448abc · 7448abc
1 parent c23a983
commit 7448abc
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 9 deletions.
diff --git a/...src/main/java/com/liskovsoft/smartyoutubetv2/common/app/presenters/PlaybackPresenter.java b/...src/main/java/com/liskovsoft/smartyoutubetv2/common/app/presenters/PlaybackPresenter.java
@@ -50,7 +50,7 @@ public boolean add(PlayerEventListener listener) {
     };
     private Video mPendingVideo;
     // Fix for using destroyed view
-    private WeakReference<PlaybackView> mPlayer = new WeakReference<>(null);
+    //private WeakReference<PlaybackView> mPlayer = new WeakReference<>(null);
 
     private PlaybackPresenter(Context context) {
         super(context);
@@ -212,15 +212,15 @@ public void setPosition(long positionMs) {
 
     // Controller methods
 
-    @Override
-    public void setView(PlaybackView view) {
-        super.setView(view);
-        mPlayer = new WeakReference<>(view);
-    }
+    //@Override
+    //public void setView(PlaybackView view) {
+    //    super.setView(view);
+    //    mPlayer = new WeakReference<>(view);
+    //}
 
     public PlaybackView getPlayer() {
-        //return getView();
-        return mPlayer.get(); // return view even if the one is destroyed
+        //return mPlayer.get(); // return view even if the one is destroyed
+        return getView();
     }
 
     public Activity getActivity() {

diff --git a/...rc/main/java/com/liskovsoft/smartyoutubetv2/common/app/presenters/base/BasePresenter.java b/...rc/main/java/com/liskovsoft/smartyoutubetv2/common/app/presenters/base/BasePresenter.java
@@ -45,7 +45,8 @@ public void setView(T view) {
     public T getView() {
         T view = mView.get();
 
-        return checkView(view) ? view : null;
+        //return checkView(view) ? view : null;
+        return view; // Fix for using destroyed view data
     }
 
     @Override