Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement R2OAS::Deprecation && Deprecated use of R2OAS.use_object_classes= #155

Merged
merged 2 commits into from
Jul 21, 2020

Conversation

yukihirop
Copy link
Owner

Summary

Resolve #148

  • Implement R2OAS::Deprecation.warn(will_remove)
  • Add R2OAS.deprecation.silenced option into Configuration
  • Deprecated use of R2OAS.use_object_classes=
  • Update docs about R2OAS.deprecation.silenced option

Implemented with considerable reference to ActiveSupport::Deprecation

Work

::R2OAS::Deprecation.will_remove(<<-MSG.squish)
     Using a R2OAS.use_object_classes= in configuration is deprecated and
     will be removed in r2-oas (v0.4.2).
MSG
DEPRECATION WARNING: Using a R2OAS.use_object_classes= in configuration is deprecated and will be removed in r2-oas (v0.4.2). (called from block in reset_config at /Users/fukudayu/RubyProjects/r2-oas/spec/support/helpers/config_helper.rb:32)

Test

./devscript/all_support_ruby.sh rspec

===== Rspec for All Support Ruby Result =====
ruby-2.3.3: 0
ruby-2.4.2: 0
ruby-2.5.8: 0
ruby-2.6.6: 0
ruby-2.7.1: 0
=============================================

Rubocop

$ bundle exec rubocop
Inspecting 209 files
.................................................................................................................................................................................................................

209 files inspected, no offenses detected

@yukihirop yukihirop added this to the v0.4.0 milestone Jul 21, 2020
@yukihirop yukihirop self-assigned this Jul 21, 2020
@yukihirop
Copy link
Owner Author

LGTM

@yukihirop yukihirop merged commit a01e484 into master Jul 21, 2020
@yukihirop yukihirop deleted the deprecated_use_object_classes branch July 21, 2020 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Deprecated] use_object_classes after v0.4.0
1 participant