-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reimplementing the plugin #154
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
git grep -l '/schema/v3/object/' | xargs sed -i '' -e "s|/schema/v3/object/|/schema/v3/object/from_routes/|g"
It was hard to understand the implementation, and there were some bugs, so it was greatly improved.
It corresponded also to the following warning ``` The following cops were added to RuboCop, but are not configured. Please set Enabled to either `true` or `false` in your `.rubocop.yml` file: - Style/AccessorGrouping (0.87) - Style/BisectedAttrAccessor (0.87) - Style/RedundantAssignment (0.87) - Style/RedundantFetchBlock (0.86) For more information: https://docs.rubocop.org/rubocop/versioning.html ```
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Until now, the plugin was applied to the document generated from the routing.
However, I realized that it was not practical, so I changed it to apply it to the document generated from the src file.
routes:oas:dist
toroutes:oas:build
.routes:oas:build
is executed.OVERRIDE_SRC=true
../oas_docs/dist/oas_doc.yml
by default.argument ref
passed to plug-in block.routes:oas:plugin
routes:oas:init
from_routes
andfrom_files
.0.88
🚨 Be sure to ensure
idempotency
when creating a plugin.Work
routes:oas:init
$ bundle exec routes:oas:init
Test
$ ./devscript/all_support_ruby rspec ===== Rspec for All Support Ruby Result ===== ruby-2.3.3: 0 ruby-2.4.2: 0 ruby-2.5.8: 0 ruby-2.6.6: 0 ruby-2.7.1: 0 =============================================
Rubocop
$ bundle exec rubocop Inspecting 203 files ........................................................................................................................................................................................................... 203 files inspected, no offenses detected