Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix backspace problem in chrome/safari #1895

Closed
wants to merge 2 commits into from
Closed

fix backspace problem in chrome/safari #1895

wants to merge 2 commits into from

Conversation

macjohnny
Copy link
Contributor

see http://yuilibrary.com/trac-archive/tickets/2532834.html for detailed problem description
fixes #2532834, but reopens #2531090, which is imho not as important as the backspace problem, since this makes the editor unusable.

see http://yuilibrary.com/trac-archive/tickets/2532834.html for detailed problem description
fixes #2532834, but reopens #2531090, which is imho not as important as the backspace problem, since this makes the editor unusable.
@yahoocla
Copy link

yahoocla commented Jul 3, 2014

CLA is valid!

@prajwalit
Copy link
Contributor

+1
Example to reproduce the problem: http://jsfiddle.net/prajwalit/8VKqD/3/

@okuryu
Copy link
Member

okuryu commented Jul 12, 2014

Thank you for your contribution. I confirmed resolved the issue.

So can we use if (e.changedType === 'tab') {} instead of switch() {}?

@macjohnny
Copy link
Contributor Author

@okuryu hi
the switch command could be replaced, i agree with you.
however, i dont understand why the build fails, since only some lines are removed and the error message (null is not a function) doesn't seem like an issue related to this removal.
how can i merge this pull request?

@macjohnny
Copy link
Contributor Author

@okuryu how about it now?

@okuryu
Copy link
Member

okuryu commented Jul 25, 2014

Okay, looks good to me. I would like to merge this in the next week.

Travis CI testing passed on Node.js 0.10. Failed on Node.js 0.8, but this is not this PR's fault.

@okuryu okuryu self-assigned this Jul 26, 2014
@okuryu
Copy link
Member

okuryu commented Jul 28, 2014

I have been cherry-picked in 8e1b4ea and 981e911. It will be available in the next release.

For the future contributions, we are working on a few branches normally. Please see Branch Information.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants