Check whether the mousedown event belonged to a valid drop target before preventing default #1778
Conversation
…ore preventing default
|
CLA is valid! |
|
Note, I did try and write some tests for this, but I'm not sure how best to simulate an actual mousedown. Simulate simulates the events rather than the actual mousedown so it's not possible to check whether the field was properly focused. |
|
//cc @tilomitra for review? |
This backports the following two patches: * yui/yui3#1757 * yui/yui3#1778
|
@tilomitra - any chance you can look at this. we have a release in around 2-3 weeks and I'd really like to backport this fix into our repo before then. |
|
Also note, this is a major breakage. Any page where DD is enabled will not be gesture scrollable by a touch-based device. |
|
This also fixes a regression caused by 9f96abc where inputs cannot receive focus via mousedown if they are nested inside of a drag node (see here http://codepen.io/Robert-Frampton/pen/FhdmD). |
|
@Robert-Frampton that's exactly the bug it's fixing. |
|
@triptych, @tilomitra - any chance of a review on this - it's now been three weeks. |
|
@andrewnicols +1 for this fix |
|
I asked @tilomitra to take a look. I'll follow up on Monday. |
|
Hey guys - sorry I was heads-down on some stuff last week. Taking a look at this now @andrewnicols. Will get back to you by EOD. |
|
It's a shame this took so damn long to "review." Thanks. This looks great. |
|
Thanks @ezequiel. Been swamped :( |
This issue affects 3.16.0 (yay).
Sorry for the spam on the previous issue. I have yet to get hub to make sensible pull requests against non-master branches.