Generate gFlags metadata xml at build time and include it in the yugabyte package #13176
Assignees
Labels
area/docdb
YugabyteDB core features
jira-originated
kind/new-feature
This is a request for a completely new feature
priority/medium
Medium priority issue
Comments
yugabyte-ci
added
area/docdb
hari90
added a commit
that referenced
this issue
Jul 8, 2022
…ld time Summary: Generate the gFlags xml metadata file for yb-master and yb-tserver at build time and include them in the release package. gFlags are defined with a hard coded value in one file which then get linked to multiple applications. The only way for one of the application to have a custom default value is to update the flag at runtime at process startup before calling google::ParseCommandLineNonHelpFlags. Ex: yb-master sets evict_failed_followers to false. New flag dump_flags_xml will dump the flag description in xml format with the current runtime value of the flags displayed as default. This is called at build time for both yb-master and yb-tserver and the output xml files are made part of the tar package. Fixes #13176 Original commit: 2a7ffce / D18153 Test Plan: ./yb_build.sh on m1 Mac and gcp Dev Server All Detective builds Reviewers: rahuldesirazu, mbautin, slingam Reviewed By: slingam Subscribers: bogdan, ybase Differential Revision: https://phabricator.dev.yugabyte.com/D18211
hari90
added a commit
that referenced
this issue
Jul 9, 2022
… time Summary: Generate the gFlags xml metadata file for yb-master and yb-tserver at build time and include them in the release package. gFlags are defined with a hard coded value in one file which then get linked to multiple applications. The only way for one of the application to have a custom default value is to update the flag at runtime at process startup before calling google::ParseCommandLineNonHelpFlags. Ex: yb-master sets evict_failed_followers to false. New flag dump_flags_xml will dump the flag description in xml format with the current runtime value of the flags displayed as default. This is called at build time for both yb-master and yb-tserver and the output xml files are made part of the tar package. Fixes #13176 Original commit: 2a7ffce / D18153 Test Plan: ./yb_build.sh on m1 Mac and gcp Dev Server All Detective builds Reviewers: rahuldesirazu, mbautin, slingam Reviewed By: slingam Subscribers: bogdan, ybase Differential Revision: https://phabricator.dev.yugabyte.com/D18212
hari90
added a commit
that referenced
this issue
Jul 9, 2022
… time Summary: Generate the gFlags xml metadata file for yb-master and yb-tserver at build time and include them in the release package. gFlags are defined with a hard coded value in one file which then get linked to multiple applications. The only way for one of the application to have a custom default value is to update the flag at runtime at process startup before calling google::ParseCommandLineNonHelpFlags. Ex: yb-master sets evict_failed_followers to false. New flag dump_flags_xml will dump the flag description in xml format with the current runtime value of the flags displayed as default. This is called at build time for both yb-master and yb-tserver and the output xml files are made part of the tar package. Fixes #13176 Original commit: 2a7ffce / D18153 Test Plan: ./yb_build.sh on m1 Mac and gcp Dev Server All Detective builds Reviewers: rahuldesirazu, mbautin, slingam Reviewed By: slingam Subscribers: bogdan, ybase Differential Revision: https://phabricator.dev.yugabyte.com/D18213
hari90
added a commit
that referenced
this issue
Jul 9, 2022
…time Summary: Generate the gFlags xml metadata file for yb-master and yb-tserver at build time and include them in the release package. gFlags are defined with a hard coded value in one file which then get linked to multiple applications. The only way for one of the application to have a custom default value is to update the flag at runtime at process startup before calling google::ParseCommandLineNonHelpFlags. Ex: yb-master sets evict_failed_followers to false. New flag dump_flags_xml will dump the flag description in xml format with the current runtime value of the flags displayed as default. This is called at build time for both yb-master and yb-tserver and the output xml files are made part of the tar package. Fixes #13176 Original commit: 2a7ffce / D18153 Test Plan: ./yb_build.sh on m1 Mac and gcp Dev Server All Detective builds Reviewers: rahuldesirazu, mbautin, slingam Reviewed By: slingam Subscribers: bogdan, ybase Differential Revision: https://phabricator.dev.yugabyte.com/D18214
This was referenced Jun 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Jira Link: DB-2860
The text was updated successfully, but these errors were encountered: