Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DictTag组件兼容传入多个字典值展示多个标签(传入值兼容单个字典值、逗号分割的多个字典值、数组包裹的字典值)的情况 #68

Merged
merged 4 commits into from
Aug 8, 2024

Conversation

GoldenZqqq
Copy link
Contributor

image

@GoldenZqqq GoldenZqqq marked this pull request as draft July 26, 2024 06:23
@GoldenZqqq GoldenZqqq marked this pull request as ready for review July 26, 2024 06:23
@GoldenZqqq GoldenZqqq closed this Jul 26, 2024
@GoldenZqqq GoldenZqqq reopened this Jul 26, 2024
@YunaiV
Copy link
Contributor

YunaiV commented Jul 28, 2024

收到收到。我预计下周会 review 下哈。

感谢贡献!

@YunaiV YunaiV self-assigned this Aug 3, 2024
@YunaiV YunaiV added the enhancement New feature or request label Aug 3, 2024
@YunaiV
Copy link
Contributor

YunaiV commented Aug 4, 2024

还有一个 tag 和 tag 之间,可能有个空隙会好点,例如说有个字段,然后默认 5px 这种

@GoldenZqqq
Copy link
Contributor Author

还有一个 tag 和 tag 之间,可能有个空隙会好点,例如说有个字段,然后默认 5px 这种

已增加用以自定义每个tag之间的间隔props['tagSpacing'],默认为5px

@YunaiV YunaiV merged commit f7d31d5 into yudaocode:master Aug 8, 2024
@YunaiV
Copy link
Contributor

YunaiV commented Aug 12, 2024

发现通过 tagSpacing 会存在一个问题?

image

貌似间隙导致的?

@GoldenZqqq
Copy link
Contributor Author

这可能是因为我给了dictTag组件最外层div弹性盒布局主侧轴居中 因为这个组件大部分情况下都用在的插槽或者在中有居中显示的需求所以不会产生位置偏移,只需要给外层元素一个display: flex;应该就不会有这个问题了
image
image

@YunaiV
Copy link
Contributor

YunaiV commented Aug 13, 2024

有没其它解决方案呢。

因为这样可能增加了使用成本哈。能不能 dict-tag 自身去 padding~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants