Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if domainlist domains are covered by regex #33

Merged
merged 5 commits into from
Nov 14, 2021
Merged

Conversation

yubiuser
Copy link
Owner

@yubiuser yubiuser commented Oct 18, 2021

If regex analysis is performed, compare exact domains on the black/whitelist against regex. Output does look like this:

  [i]  You hit a special case
       Your personal domainlist contains at least one domain that is also coverd by at least
       one of your regexs.


domain                              regex_id  regex                                                                                                                                                                                                                                            
----------------------------------  --------  -------------------------------------
log.expatgoneforeign.com            51        ^logs?\..*\..*$                                                                                                                                                                                                                                  
track.aliexpress.com                77        ^track(ing)?[0-9]*[_.-]                                                                                                                                                                                                                          
tracking-services.ao.com            77        ^track(ing)?[0-9]*[_.-]        

Might help to remove manually added domains which are also covered by regex.
Fixes issue #32

Additionally bump version to 2.6 and enforce up-to-date Pihole version (dnsmasq 2.87)

@yubiuser yubiuser linked an issue Oct 18, 2021 that may be closed by this pull request
@yubiuser yubiuser changed the title Compare regex coverage with blacklisted domains Check if blacklisted domains are covered by regex Oct 18, 2021
@yubiuser yubiuser changed the title Check if blacklisted domains are covered by regex Check if domainlist domains are covered by regex Oct 18, 2021
@yubiuser yubiuser marked this pull request as ready for review October 18, 2021 17:48
@yubiuser yubiuser merged commit 3752357 into master Nov 14, 2021
@yubiuser yubiuser deleted the regex_blacklist branch November 14, 2021 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Does regex checking account for Filter Lists?
1 participant