-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] Implement release workflow #32876
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could not test the devscripts under 2.6, but also thats not required as far as the build process goes, so...
Additional targets can be added later to the build.yml
if desired
Exactly. Anyone who wants to run the scripts with 2.6 should be able to fix any problems.
Sure. But this is making the same ones as the nightly, isn't it, and that's all we need for now, except that maybe there should be two versions of the |
I think adding another target for this might not make sense. Many modern os have already switched to If you disagree ill add the target though. Just let me know what to call it |
It seems that macOS typically installs a If only there were some way to formulate a #!/bin/sh
exec python3 "$@" || exec python "$@" In all the systems where I've tried it, a sed command works (preserving the executable permission if it was set): sed -i -e '1 s/python$/python3/' youtube-dl As POSIX-y systems are meant to hide any platform differences between "text" and "binary" files, maybe this is good enough, once the shipped default has been decided. Otherwise, a separate target, say |
Done. See 2024.07.25 release for results |
Side note, @dirkf, do you have access to the PyPI package? Anyways, if needed it can easily be added based on yt-dlp workflow, or done later at any point |
What is the holdup on this? Anything that can be done to get this merged? |
@dirkf is this PR being considered? |
Definitely, but #32905 needs to be sorted before I can get back to it. |
Please follow the guide below
x
into all the boxes [ ] relevant to your pull request (like that [x])Before submitting a pull request make sure you have:
master
for successful application of this PR, and the 2024.07.23 and 2024.07.23.1 for example releases, including changelog. Writing tests for CI results is hardIn order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
Implements an automated release workflow, similar to yt-dlp's (Rewrite of the nightly workflow as an automated
workflow_dispatch
action). Also removes the old, obsolete build scripts in favor of using the current workflow.It supports:
make_changelog.py
can be backported if the yt-dlp commit format will be adaptedAfter this is merged, the only barrier to publishing a new release will be running the "Release" workflow.
Closes #31585