Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👷 use latest major version for actions/checkout #32672

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

thomasmerz
Copy link

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

Use latest major version of actions/checkout for GitHub Actions.

@dirkf
Copy link
Contributor

dirkf commented Jan 13, 2024

What would be useful is to go through the CI here, and in the dependent actions repos here, and in the nightly repo (separate PRs, obvs) changing all uses to v4 **and setting progress: false in the with parameter list (see the action changelog and PR 1067 describing this). If you, or anyone, does do so, pls announce any new PRs from the other repos here.

@thomasmerz
Copy link
Author

Hey @dirkf , are you interested in my PR or should I close it? Can I help in anyway with your CI or what will be done…? 🤔

@dirkf
Copy link
Contributor

dirkf commented Jun 5, 2024

I just love the pointless version dependency hell that is the GH actions ecosystem.

Apparently changing to v4 might clear some warnings about node.js versions. Why that needs new major version is far from clear. But we do get the new --show-progress option that we should set, as above. Instead we could set version master, or whatever syntax, if it exists, that means v4 or later (is this field actually a git commit-ish ?)

Then we need to make the equivalent changes in the nightly repo.

Copy link
Contributor

@dirkf dirkf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think?

.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@dirkf
Copy link
Contributor

dirkf commented Jun 12, 2024

That looks better! But I'm still undecided whether it's appropriate to use @v4, @master, or no version.

To expand on #32672 (comment), in principle it should be enough to use @v4. However the action devs don't maintain a v4 interface. Instead if they want to use a new version of, say, Node (an internal change that should not affect action functionality) they make the change in the latest release only, so propagating their technical debt to all users of the action. Those users then have to update the action version even if they are not using any new features of the action.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants