Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: ignore deprecation warning from pandas (Pyarrow will become a required dependency) #4784

Merged

Conversation

neutrinoceros
Copy link
Member

PR Summary

As noted by @jzuhone in #4782, this warning makes half of CI red.

I don't think we care about it, but for completion, here it is in full:

DeprecationWarning: 
Pyarrow will become a required dependency of pandas in the next major release of pandas (pandas 3.0),
(to allow more performant data types, such as the Arrow string type, and better interoperability with other libraries)
but was not found to be installed on your system.
If this would cause problems for you,
please provide us feedback at https://github.com/pandas-dev/pandas/issues/54466

@neutrinoceros neutrinoceros force-pushed the tst/ignore-pandas-pyarrow-warning branch from d5bdfd7 to 704a7c6 Compare January 23, 2024 08:20
@neutrinoceros neutrinoceros added the tests: running tests Issues with the test setup label Jan 23, 2024
@neutrinoceros neutrinoceros added this to the 4.3.1 milestone Jan 23, 2024
@neutrinoceros neutrinoceros force-pushed the tst/ignore-pandas-pyarrow-warning branch from 704a7c6 to dc1e7e6 Compare January 23, 2024 09:02
@neutrinoceros
Copy link
Member Author

CI is still half red... but for a different reason.
Specifically, there was a change in pandas 2.2 that broke Firefly. For now, I've just noted it within the culprit PR. This isn't a yt problem, but we might consider pinning pandas in our tests if this isn't remedied promptly.

@neutrinoceros
Copy link
Member Author

I opened two PRs upstream to fix some compatibility issues between Firefly and the rest of the world.
ageller/Firefly#177
agurvich/abg_python#4

If both patches are accepted and released shortly, no further action should be required here
ping @agurvich

@agurvich
Copy link
Contributor

Never say I don't respond to pings! Updated both on pypi, hopefully that helps y'all's CI. Cheers @neutrinoceros !

@neutrinoceros
Copy link
Member Author

Awesome, thank you so much !

@neutrinoceros neutrinoceros force-pushed the tst/ignore-pandas-pyarrow-warning branch from dc1e7e6 to 2848ceb Compare January 23, 2024 13:29
@neutrinoceros
Copy link
Member Author

neutrinoceros commented Jan 23, 2024

There's another unrelated failure left with yt/visualization/volume_rendering/tests/test_scene.py::test_annotations. I don't understand where it's coming from and I don't have time left to dig into it. Will report.
edit: this is #4785

@yt-fido test this please

@matthewturk matthewturk merged commit dbe0965 into yt-project:main Jan 26, 2024
9 of 12 checks passed
meeseeksmachine pushed a commit to meeseeksmachine/yt that referenced this pull request Jan 26, 2024
…das (Pyarrow will become a required dependency)
@neutrinoceros neutrinoceros deleted the tst/ignore-pandas-pyarrow-warning branch January 26, 2024 15:42
neutrinoceros added a commit that referenced this pull request Jan 26, 2024
…4-on-yt-4.3.x

Backport PR #4784 on branch yt-4.3.x (TST: ignore deprecation warning from pandas (Pyarrow will become a required dependency))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug tests: running tests Issues with the test setup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants