-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: public API render
methods to PlotContainer
and FixedResolutionBuffer
#4121
Merged
matthewturk
merged 3 commits into
yt-project:main
from
neutrinoceros:plotcontainer_render_method
Sep 23, 2022
Merged
ENH: public API render
methods to PlotContainer
and FixedResolutionBuffer
#4121
matthewturk
merged 3 commits into
yt-project:main
from
neutrinoceros:plotcontainer_render_method
Sep 23, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
just noticed that |
neutrinoceros
changed the title
ENH: add a PlotContainer.render method (public interface for _setup_plots)
ENH: public API Sep 13, 2022
render
methods to PlotContainer and FixedResolutionBuffer
neutrinoceros
changed the title
ENH: public API
ENH: public API Sep 13, 2022
render
methods to PlotContainer and FixedResolutionBufferrender
methods to PlotContainer
and FixedResolutionBuffer
I like the idea, but I'm not sure why we'd want to add |
yup I actually don't think it's needed. |
…where __getitem__ was used but the return value wasn't captured)
neutrinoceros
force-pushed
the
plotcontainer_render_method
branch
from
September 21, 2022 18:51
ce5a58e
to
a27407e
Compare
5 tasks
@matthewturk I removed the unnecessary decorator, this is now ready for review again |
matthewturk
approved these changes
Sep 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
A simple addition to the public interface would be useful in #4118 to avoid using private methods directly.
Content:
_setup_plots
method in user docsFor backward compatibility, I avoided simply renaming
_setup_plots
.Hopefully the intented usage is clear from the docstring and the docs update.
I'm not completely certain that my use of the
@validate_plot
is warranted or justified, and I would particularly appreciate feedback specifically on this.