Rounded corners for legacy xrender backend #551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yshui
force-pushed
the
rounded-corners-legacy-xrender
branch
from
1729164 to
4bd612d
Compare
Codecov Report
@@ Coverage Diff @@
## next #551 +/- ##
==========================================
- Coverage 38.21% 37.98% -0.24%
==========================================
Files 46 46
Lines 9056 9186 +130
==========================================
+ Hits 3461 3489 +28
- Misses 5595 5697 +102
|
yshui
force-pushed
the
rounded-corners-legacy-xrender
branch
from
4bd612d to
c523745
Compare
|
I think this change is pretty isolated, doesn't have much impact outside the legacy backends. |
tryone144
requested changes
Nov 30, 2020
Comment on lines
+297
to
+296
| xcb_render_color_t black = { | ||
| .red = 255, .blue = 255, .green = 255, .alpha = 255}; |
There was a problem hiding this comment.
Isn't this actually white? Or am I missing something? Should matter though as long as it works.
There was a problem hiding this comment.
yeah, this is white. maybe it's named black because we do a OP_OUT_REVERSE later, so it's inverted? I can only guess.
Signed-off-by: Yuxuan Shui <[email protected]>
Authored-by: Samuel Hand <[email protected]>
Allows the user to selectively disable rounded corners. Authored-by: Samuel Hand <[email protected]>
Signed-off-by: Yuxuan Shui <[email protected]>
Signed-off-by: Yuxuan Shui <[email protected]>
yshui
force-pushed
the
rounded-corners-legacy-xrender
branch
from
2689c9a to
cb41ea9
Compare
tryone144
approved these changes
Nov 30, 2020
|
@tryone144 Thanks. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #480 and #229