Fixed Install page history broken (apache#18182)

* fix install option block history broke * when history goes back, avoid button default css blue outline * use appropriate parameter name * format scss change
ys2843 · Sep 8, 2020 · 2f25012 · 2f25012
1 parent 0e86a91
commit 2f25012
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/docs/static_site/src/_sass/minima/_getting_started.scss b/docs/static_site/src/_sass/minima/_getting_started.scss
@@ -172,6 +172,11 @@ ul.dropdown-content {
       background-color: $color-mxnet;
       color: $grey-color-light;
     }
+
+    &:focus {
+      outline: 0;
+    }
+
   }
 
 

diff --git a/docs/static_site/src/assets/js/options.js b/docs/static_site/src/assets/js/options.js
@@ -45,7 +45,7 @@ $(document).ready(function () {
         }
     }
 
-    function setSelects(urlParams) {
+    function setSelects(urlParams, dontPushState) {
         let queryString = '?';
         $('button.opt').removeClass('active');
         if (urlParams.get('version')) {
@@ -87,7 +87,7 @@ $(document).ready(function () {
 
         showContent();
 
-        if (window.location.href.indexOf("/get_started") >= 0) {
+        if (window.location.href.indexOf("/get_started") >= 0 && !dontPushState) {
             history.pushState(null, null, queryString);
         }
     }
@@ -129,5 +129,8 @@ $(document).ready(function () {
     $('.opt-group').on('click', '.opt', setContent);
     $('.install-widget').css("visibility", "visible");
     $('.install-content').css("visibility", "visible");
+    $(window).on('popstate', function(){
+        setSelects(urlSearchParams(window.location.search), true);
+    });
 
 });