Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration parameter that allows to skip discovering interfaces #476

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fdellwing
Copy link

This adds a new configuration parameter that allows the user to completly skip calling is_same_machine which is very expensive once the machine has a critical mass of interfaces.

This comes with the downside of having to do more work in setting up potential unnecessary binds.


We have a server with around 10k network interfaces and current versions of sslh are absolutly unusable there.

This adds a new configuration parameter that allows the user to completly
skip calling `is_same_machine` which is very expensive once the machine
has a critical mass of interfaces.

This comes with the downside of having to do more work in setting up
potential unnecessary binds.
@yrutschle
Copy link
Owner

Thanks for the contribution.
I don't remember the rationale for some of the code in that area: does your patch not affect transparent proxying?
(I'm a bit confused about how transparent proxying still works if the target is on localhost: I feel it should still need to bind the server-side connection)

@fdellwing
Copy link
Author

We found later after more testing, that for transparent proxying on localhost we can not return there. So we need to actually skip calling is_same_machine but run the following code regardless. For this the config check could be moved into the is_same_machine function or and additional layer of if could be used. Which one do you prefer?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants