Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

raft调用InstallSnapshot存在重复的问题 #57

Closed
Pyolar opened this issue Apr 10, 2024 · 1 comment · Fixed by #78
Closed

raft调用InstallSnapshot存在重复的问题 #57

Pyolar opened this issue Apr 10, 2024 · 1 comment · Fixed by #78
Labels
good first issue Good for newcomers

Comments

@Pyolar
Copy link

Pyolar commented Apr 10, 2024

Snipaste_2024-04-10_14-48-52
这里为什么要向kvserver推送两次安装的日志信息
@578223592 578223592 changed the title raft远程调用InstallSnapshot问题 raft调用InstallSnapshot存在重复的问题 Apr 21, 2024
@578223592
Copy link
Collaborator

578223592 commented Apr 21, 2024 •
edited
Loading

@Pyolar 感谢指出，这里确实存在重复推送的问题。
简单的删除下方代码所在行应该就可以了。

  applyChan->Push(msg);

如果你想来一个贡献，欢迎pr。
或者我会删除它。

@578223592 578223592 mentioned this issue Apr 21, 2024
Open
11 tasks
@578223592 578223592 added the good first issue Good for newcomers label Apr 23, 2024
beanljun added a commit to beanljun/KVstorageBaseRaft-cpp that referenced this issue Jul 29, 2024
@beanljun
raft调用InstallSnapshot存在重复的问题 youngyangyang04#57
3d69c57
@578223592 578223592 linked a pull request Aug 29, 2024 that will close this issue
InstallSnapshot重复的问题 #78
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

InstallSnapshot重复的问题 beanljun/KVstorageBaseRaft-cpp
2 participants
@578223592 @Pyolar