-
Notifications
You must be signed in to change notification settings - Fork 392
Implement Linux memory policy #3230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
n4mlz
wants to merge
46
commits into
youki-dev:main
Choose a base branch
from
n4mlz:feat/set-mempolicy
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
46 commits
Select commit
Hold shift + click to select a range
823c98d
Implement set_mempolicy syscall and related error handling
n4mlz 2c3b9e0
Update memory policy validation in setup_memory_policy function
n4mlz 14a114e
Add memory policy tests and integrate into test framework
n4mlz 80fa98b
Refactor memory policy tests to use ConditionalTest for NUMA-dependen…
n4mlz e40dceb
Add memory policy test for empty mode in tests
n4mlz 449b953
Refactor memory policy mode usage
n4mlz 666a81e
Fix maxnode calculation in build_nodemask function
n4mlz 97255c1
Split Linux memory policy processing into files
n4mlz d2d971f
Refactor setup_memory_policy function to improve readability and erro…
n4mlz ffc9bd7
Refactor memory policy flag usage for improved clarity
n4mlz 81a1476
Remove memory policy test case for empty policy
n4mlz ec948a4
Refactor memory policy validation to simplify function signature and …
n4mlz 652f1d3
Refactor memory policy tests to remove conditional checks and simplif…
n4mlz 9cdbba3
Add documentation for setup_memory_policy function
n4mlz cbda2d9
Refactor setup_memory_policy to streamline flag handling and improve …
n4mlz c906009
Refactor setup_memory_policy to separate validation from syscall exec…
n4mlz 178b907
Unify MPOL_DEFAULT and MPOL_LOCAL tests
n4mlz 4fb74dd
Fix memory policy test to match maxnode calculation
n4mlz 273ef96
Remove memory policy test case for empty policy
n4mlz 4223938
Remove duplicate case
n4mlz e9ef9fa
Add memory policy node verification
n4mlz e12eff1
Fix test name
n4mlz a8ea1f8
Use libc::c_ulong for nodemask
n4mlz e7ddf1f
Remove unused error variant for invalid memory policy mode
n4mlz d9ac825
Refactor import statements for clarity and consistency
n4mlz 2f0a1e2
Enhance error messages in validate_memory_policy to include mode names
n4mlz 18d2cce
Fix error message in validate_memory_policy for expected node binding
n4mlz b15150d
Refactor numa_maps_indicates_node0 function to simplify parameters an…
n4mlz 90c9024
Refactor validate_memory_policy to simplify logic
n4mlz 9fcc646
Update oci-spec version to 0.8.3
n4mlz bee064e
Refactor validate_memory_policy to improve parsing logic and enhance …
n4mlz c971475
Update runc installation to version 1.4.0-rc.2 for memory policy support
n4mlz 8c9bd9e
Refactor numa_maps_indicates_node0 to improve node parsing logic
n4mlz 7449697
Add empty flags to memory policy test cases
n4mlz f5f86eb
Add empty nodes to memory policy test cases
n4mlz eb39c93
Format import order
n4mlz 0133c00
Merge branch 'main' of https://github.com/youki-dev/youki into feat/s…
n4mlz ab4a91a
Merge branch 'main' of https://github.com/youki-dev/youki into feat/s…
n4mlz 92c61b0
Update memory policy validation to enhance node set handling
n4mlz 7c53fea
Lint fix
n4mlz d66d9a1
Revert changes related to the runc version
n4mlz 8189200
Update memory policy tests to use ConditionalTest
n4mlz a7e0a1d
Merge branch 'main' of https://github.com/youki-dev/youki into feat/s…
n4mlz 6de003f
Fix formatting of Cargo.toml
n4mlz 623ca95
Refactor memory policy for improved readability and maintainability
n4mlz 088bfe6
Merge branch 'main' of https://github.com/youki-dev/youki into feat/s…
n4mlz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’m sorry for the trouble.
validate-contest-runcis intended to verify the validity of newly added integration tests by running them with runc.Thinking ahead to other integration tests we might add, I believe it’s best to use the stable version here.
If the memory policy test fails, we can skip it.
Please refer to the following.
https://github.com/youki-dev/youki/blob/main/tests/contest/contest/src/tests/fd_control/mod.rs#L100