Continued #258: install.sh Add support for multiple shells
#260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most `~/.profile` files already add `~/.local/bin` to PATH; if not, we can add it to the respective shell configuration file. Added support for - `bash` - `zsh` - `fish` - `ksh` - `xonsh` - `csh` - `tcsh` There is no way for a child process (this install script, always running in `bash`) to directly affect the environment variables of the parent process (the invoking shell), so the best we can do in this case is instruct the user to re-source or religion. Also, changed to prepend instead of append for consistency.
✅ Deploy Preview for superfile ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Thanks :)! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is continued from #258 (which was already merged, so I couldn't add commits there).
Most
~/.profilefiles already add~/.local/bintoPATH; if not, we can add it to the respective shell configuration file.Added support for
bashzshfishkshxonshcshtcshThere is no way for a child process (this install script, always running in
bash) to directly affect the environment variables of the parent process (the invoking shell), so the best we can do in this case is instruct the user to re-source or relogin.Also, changed to prepend instead of append to
PATHfor consistency.