code review #128
Merged
code review #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These brands should be written with this exact format: - macOS - GitHub
YYYY/MM/DD is barely used, and only in: - Rwanda - Iran - Guinea - South Africa More information here https://en.wikipedia.org/wiki/List_of_date_formats_by_country
|
Please accept my code review. |
|
I plan to contribute by looking at your Go code, and possibility help you to add GitHub actions to maintain the code quality. I will open a new PR about it, let's say I'm checking your availability/interest in code review with this PR, before starting to work really deep in the code. |
|
Wow thank you so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I started looking at your project and I found small typos issues.
Fixes
Type of change
Please delete options that are not relevant.
Tests
N/A