Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confirm before quit #155

Closed
onjour opened this issue May 16, 2024 · 6 comments
Closed

Confirm before quit #155

onjour opened this issue May 16, 2024 · 6 comments
Labels
enhancement New feature or request

Comments

@onjour
Copy link

onjour commented May 16, 2024

The part you want to Enhancement
Add a dialog prompt to confirm before quitting Superfile, especially when doing operations / processses

Why it is necessary to enhancement
Right now, if I'm in the middle of file transfers and I press the Esc key by error one single time my whole queue is lost

@onjour onjour added the enhancement New feature or request label May 16, 2024
@yorukot
Copy link
Owner

yorukot commented May 16, 2024

I think this is a good idea and I will add this feature!

@AnshumanNeon
Copy link
Contributor

i'll work on it. its been some time anyway. i'm quite surprised how much superfile's src code has changed. i mean better organisation is there. but it is a little confusing for me.

@AnshumanNeon
Copy link
Contributor

i'm working on it and it seems like it needs a little bit of boilerplate to add a new quitwarn modal. but it is easy. at least it'll give my muscles some warm-up

@yorukot yorukot moved this from Feature to Done in superfile todo list Jun 2, 2024
@yorukot yorukot closed this as completed by moving to Done in superfile todo list Jun 2, 2024
@yorukot yorukot moved this from Done to Feature in superfile todo list Jun 2, 2024
@yorukot yorukot reopened this Jun 2, 2024
@AnshumanNeon
Copy link
Contributor

@yorukot can you work on this please? I won't be able to complete it. I am too much comitted in a lot of things. Also I accidentally discarded my commits in order to keep my fork up to date with the official master branch. Which is why, all my progress is gone. Sorry.

@yorukot
Copy link
Owner

yorukot commented Jun 6, 2024

Of course. No need to apologize!

yorukot added a commit that referenced this issue Jun 6, 2024
@yorukot yorukot moved this from Feature to Done in superfile todo list Jun 6, 2024
@yorukot yorukot closed this as completed by moving to Done in superfile todo list Jun 6, 2024
@yorukot
Copy link
Owner

yorukot commented Jun 6, 2024

I think this feature should have been successfully implemented, but if you have any questions please let me know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

No branches or pull requests

3 participants