Update protocol to support multi-user undo and redo on Text.edit #644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyemmie
added
enhancement 🌟
2 tasks
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #644 +/- ##
==========================================
- Coverage 49.47% 49.19% -0.28%
==========================================
Files 69 69
Lines 9951 10007 +56
==========================================
Hits 4923 4923
- Misses 4512 4568 +56
Partials 516 516
☔ View full report in Codecov by Sentry. |
hackerwins
force-pushed
the
main
branch
3 times, most recently
from
7892142
to
fdc2e1c
Compare
hackerwins
force-pushed
the
main
branch
2 times, most recently
from
fbc6098
to
7d65a57
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: A new operation,
EditReverse, is proposed to support multi-user undo and redo functionality in text.edit. (yorkie-team/yorkie-js-sdk#635)To support this, the server also needs to modify the protocol buffer. This PR defines the new
EditReverseoperation and modifies the protocol buffer to allow replicas to send and receive EditReverse operations.Which issue(s) this PR fixes:
It fixs #49 partially.
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation:
Checklist: