Migrate RPC to ConnectRPC #698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #698 +/- ##
===========================================
+ Coverage 68.67% 81.75% +13.08%
===========================================
Files 58 57 -1
Lines 9011 4161 -4850
Branches 811 805 -6
===========================================
- Hits 6188 3402 -2786
+ Misses 2561 502 -2059
+ Partials 262 257 -5 ☔ View full report in Codecov by Sentry. |
hackerwins
force-pushed
the
connectrpc
branch
from
03d6a6a to
7200dfe
Compare
hackerwins
force-pushed
the
connectrpc
branch
4 times, most recently
from
0da6a70 to
e05669b
Compare
hackerwins
force-pushed
the
connectrpc
branch
from
e05669b to
ca54c14
Compare
hackerwins
force-pushed
the
connectrpc
branch
2 times, most recently
from
d0a2dec to
d43e0bc
Compare
hackerwins
force-pushed
the
connectrpc
branch
from
d43e0bc to
2b52110
Compare
|
The bundle size has been reduced after introducing connect-rpc. grpc-web: connect-rpc: Related to #434 |
hackerwins
force-pushed
the
connectrpc
branch
from
f489c1f to
8bcca6c
Compare
hackerwins
approved these changes
Dec 15, 2023
hackerwins
added a commit
that referenced
this pull request
Dec 15, 2023
With this support, we can resolve several issues: - Removes dependency with Envoy proxy to communicate with grpc-web - Reduces SDK bundle size by half bundle size of #434 - Standardizes API interfaces to powerful fetch API For more information about this migration, follow: yorkie#703 --------- Co-authored-by: Youngteac Hong <[email protected]>
2 tasks
hackerwins
added a commit
that referenced
this pull request
Jan 8, 2024
A script error occurred when creating a snapshot due to a typo in the converter during migrating to ConnectRPC. #698 This commit fixes the typo.
2 tasks
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
Migrate RPC to ConnectRPC.
For more information about this migration, follow: yorkie-team/yorkie#703
With this support, you can resolve several issues:
Any background context you want to provide?
Note
We need to revert docker-compose yorkie image toyorkieteam/yorkie:lastestinstead ofkrapi0314/yorkie:testWhat are the relevant tickets?
Fixes yorkie-team/yorkie#668
Checklist