Fix missing collection of removed elements from the root #676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Yourim Cha <[email protected]>
hackerwins
force-pushed
the
fix-invalid-garbage-length
branch
from
112c351
to
c274c5f
Compare
hackerwins
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #676 +/- ##
==========================================
+ Coverage 67.83% 67.90% +0.06%
==========================================
Files 58 58
Lines 8734 8737 +3
Branches 784 785 +1
==========================================
+ Hits 5925 5933 +8
+ Misses 2550 2546 -4
+ Partials 259 258 -1
☔ View full report in Codecov by Sentry. |
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
Fix missing collection of removed elements from the root.
A document has two structures representing the user data: clone and root. When elements are removed by
document.update, they are collected toremovedElementMapByCreatedAtfor garbage collection.However, we found a bug in that the collection is missing in the root. So this commit fixes it.
Any background context you want to provide?
A. Luckily, the collection is not missing in Yorkie.
https://github.com/yorkie-team/yorkie/blob/a000a29d81d7e6557edfbe3cb5f2ce17b203c634/pkg/document/operations/set.go#L68-L72
B. Remove
ClonefromDocument.We've added
cloneto protect the root from unintended updates caused by document.update. However, keeping the clone and the root in sync is challenging and consumes twice as much memory. Therefore, it is better to remove the clone after introducing reverse operations fromDocument.history.What are the relevant tickets?
Fixes #
Checklist