-
Notifications
You must be signed in to change notification settings - Fork 27
Command System Remake #141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
I need some time to think about this. Im not sure this is really necessary, maybe I'm not understanding though |
oqyh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removing StringComparison.OrdinalIgnoreCase
will force people !gunmenu
and will ignore !GuNMenu !GUNMENU
it will lead to open this issue again
#45
not good
|
This PR is more "standard" but it gives less flexibility to the commands themselves, so Im hesitant to change it. Does CS# support case insensitive commands maybe? |
|
if you want to solve if (CenterMenuCommands.Any(cmd => cmd.Equals( |






I have removed player chat event based command system and integrated it to CS# command system. By doing this players can change prefix of command by CS# settings and no need to add different prefixes to this plugin config.
This also completely solves issue #128
Since this is a big change. Server owners should configure their config by new default config.
Waiting your feedbacks.