Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add custom lldinit for a scheme #929

Merged
merged 5 commits into from
Aug 12, 2020
Merged

Add custom lldinit for a scheme #929

merged 5 commits into from
Aug 12, 2020

Conversation

polac24
Copy link
Contributor

@polac24 polac24 commented Aug 10, 2020

Adds support for customLLDBInit, added to XcodeProj in tuist/XcodeProj#553

@brentleyjones
Copy link
Collaborator

Nice! Can you also add this to the fixture tests?

@polac24
Copy link
Contributor Author

polac24 commented Aug 11, 2020

@brentleyjones, sure, added one.

keith
keith approved these changes Aug 11, 2020
View reviewed changes
Copy link
Collaborator

@keith keith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we're behind on XcodeGen so I haven't tested this but we have an internal script that adds these after the fact and they do about the same thing. thanks for doing this!

yonaskolb
yonaskolb approved these changes Aug 12, 2020
View reviewed changes
Copy link
Owner

@yonaskolb yonaskolb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @polac24!

@yonaskolb yonaskolb merged commit 1d2a284 into yonaskolb:master Aug 12, 2020
@polac24 polac24 deleted the 20200615-custom-lldinit branch September 7, 2020 10:55
@codeman9 codeman9 mentioned this pull request Sep 29, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yonaskolb yonaskolb yonaskolb approved these changes

@keith keith keith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@polac24 @brentleyjones @keith @yonaskolb