-
Notifications
You must be signed in to change notification settings - Fork 821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Treat all directories with known UTI as file wrapper #896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switched to using |
brentleyjones
approved these changes
Jun 19, 2020
toshi0383
approved these changes
Jun 21, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let’s see how it goes 👍
@KhaosT Can you add a changelog entry? |
✅ Done~ Always forget that 😅 |
Not sure if it's a bugfix though. |
KhaosT
changed the title
Bugfix: Treat all directories with known UTI as file wrapper
Treat all directories with known UTI as file wrapper
Jun 23, 2020
Renamed title :) |
yonaskolb
approved these changes
Jun 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updated the logic that used to determine if we should apply special treatment for certain folders to mirror the behavior closer to what we had before #826. With this change, a folder will only be considered as a normal folder if it contains an extension that's not mapped to a known UTI.
This PR addressed the issue reported in #894.