Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat all directories with known UTI as file wrapper #896

Merged
merged 6 commits into from
Jun 25, 2020

Conversation

KhaosT
Copy link
Contributor

@KhaosT KhaosT commented Jun 18, 2020

This PR updated the logic that used to determine if we should apply special treatment for certain folders to mirror the behavior closer to what we had before #826. With this change, a folder will only be considered as a normal folder if it contains an extension that's not mapped to a known UTI.

This PR addressed the issue reported in #894.

@KhaosT
Copy link
Contributor Author

KhaosT commented Jun 19, 2020

Switched to using fileGroups instead of target so it doesn't get copied to the final destination.

Copy link
Collaborator

@toshi0383 toshi0383 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let’s see how it goes 👍

@brentleyjones
Copy link
Collaborator

@KhaosT Can you add a changelog entry?

@KhaosT
Copy link
Contributor Author

KhaosT commented Jun 22, 2020

✅ Done~ Always forget that 😅

CHANGELOG.md Outdated Show resolved Hide resolved
@toshi0383
Copy link
Collaborator

Not sure if it's a bugfix though.

@KhaosT KhaosT changed the title Bugfix: Treat all directories with known UTI as file wrapper Treat all directories with known UTI as file wrapper Jun 23, 2020
@KhaosT
Copy link
Contributor Author

KhaosT commented Jun 23, 2020

Renamed title :)

@yonaskolb yonaskolb merged commit 37e1f72 into yonaskolb:master Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants