Skip to content

Rely on fileReference instead of adding new synchronizedRootGroup #1557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yonaskolb merged 1 commit into from
Jul 11, 2025
Merged

Rely on fileReference instead of adding new synchronizedRootGroup #1557

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Sources/XcodeGenKit/PBXProjGenerator.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1456,7 +1456,7 @@ public class PBXProjGenerator {
}

// add fileSystemSynchronizedGroups
let synchronizedRootGroups = sourceFiles.compactMap { $0.synchronizedRootGroup }
let synchronizedRootGroups = sourceFiles.compactMap { $0.fileReference as? PBXFileSystemSynchronizedRootGroup }
if !synchronizedRootGroups.isEmpty {
targetObject.fileSystemSynchronizedGroups = synchronizedRootGroups
}
Expand Down
4 changes: 1 addition & 3 deletions Sources/XcodeGenKit/SourceGenerator.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ struct SourceFile {
let fileReference: PBXFileElement
let buildFile: PBXBuildFile
let buildPhase: BuildPhaseSpec?
var synchronizedRootGroup: PBXFileSystemSynchronizedRootGroup?
}

class SourceGenerator {
Expand Down Expand Up @@ -706,14 +705,13 @@ class SourceGenerator {
// TODO: adjust if hasCustomParent == true
rootGroups.insert(syncedRootGroup)

var sourceFile = generateSourceFile(
let sourceFile = generateSourceFile(
targetType: targetType,
targetSource: targetSource,
path: path,
fileReference: syncedRootGroup,
buildPhases: buildPhases
)
sourceFile.synchronizedRootGroup = syncedRootGroup
sourceFiles.append(sourceFile)
}

Expand Down