Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove GraphViz feature #1485

Merged
merged 2 commits into from
Jul 2, 2024
Merged

Conversation

giginet
Copy link
Collaborator

@giginet giginet commented Jul 2, 2024

closes #1483 closes #1462

I found XcodeGen can't build with Xcode 16 and Swift 6 compilers due to GraphViz.

It might be caused by Swift compiler's bug so it will be fixed until the stable release.
However, GraphViz is no longer maintained, so I suggest dropping this dependency for future maintainability.

This PR drops dump --type graphviz feature.

Copy link
Collaborator

@freddi-kit freddi-kit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found there is graphviz in

"location" : "https://github.com/SwiftDocOrg/GraphViz.git",
but not related so much 😂

@yonaskolb yonaskolb merged commit 7eb5e9b into yonaskolb:master Jul 2, 2024
2 checks passed
@giginet giginet deleted the remove-graphviz branch July 2, 2024 07:46
@giginet
Copy link
Collaborator Author

giginet commented Jul 2, 2024

I found there is graphviz in

I checked this test fixture. It depends on XcodeGenKit itself, so it's better to update them for the current situation.

asifmohd added a commit to asifmohd/XcodeGen that referenced this pull request Oct 22, 2024
asifmohd added a commit to asifmohd/XcodeGen that referenced this pull request Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build is broken on Xcode 16 Beta 1 due to GraphViz Deintegration of GraphViz
3 participants