Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include folder (SPM packages) in group sorting logic #1466

Merged
merged 1 commit into from
May 17, 2024

Conversation

jflan-dd
Copy link
Contributor

Add ability to sort SPM packages within a project by allowing groupOrdering to apply to both groups and folders.

Same motivation as #1366

@jflan-dd
Copy link
Contributor Author

@yonaskolb what do you think of this change?

For our project we consider it pretty important to be able to sort the local SPM packages. Do you think combining them with the group sorting logic makes sense, or should they have their own dedicated logic somewhere?

Copy link
Owner

@yonaskolb yonaskolb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks @jflan-dd

@yonaskolb yonaskolb merged commit d99e448 into yonaskolb:master May 17, 2024
2 checks passed
@jflan-dd jflan-dd deleted the sort-folders branch May 17, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants