Supports specifying multiple package products #1395
Conversation
There was a problem hiding this comment.
👍
Please add some test case under Fixtures, like: https://github.com/yonaskolb/XcodeGen/blob/master/Tests/Fixtures/SPM/project.yml
Docs/ProjectSpec.md
Outdated
| @@ -646,6 +646,7 @@ targets: | |||
|
|
|||
| **Package dependency** | |||
| - [ ] **product**: **String** - The product to use from the package. This defaults to the package name, so is only required if a Package has multiple libraries or a library with a differing name | |||
There was a problem hiding this comment.
IMO, we can deprecate product and we can set products as standard way.
@yonaskolb what do you think?
There was a problem hiding this comment.
I think we have to keep it around due to it's ability to set different options related to the dependency itself, like you mention below
| dependencies: | ||
| - package: FooFeature | ||
| products: | ||
| - FooDomain | ||
| - FooUI |
There was a problem hiding this comment.
How can we handle if we want to do below case?
- FooDomain: embed = true
- FooUI: embed = false
There was a problem hiding this comment.
My thinking was that people would use product when needing fine-grained control and products (with an s) when products are to be added the same way.
dependencies:
- package: FooFeature
product: FooDomain
embed: true
- package: FooFeature
product: FooUI
embed: falseAlternatively, products should be objects as shown below while also supporting products as plain strings. If both aren't supported, the benefit of products become too little.
So both of these would be valid:
dependencies:
- package: FooFeature
products:
- name: FooDomain
embed: true
- name: FooUI
embed: falsedependencies:
- package: FooFeature
products:
- FooDomain
- FooUIThere was a problem hiding this comment.
@simonbs the embed property is part of the Dependency type, so the list of objects would break that relationship.
I think having to split out into seperate product is fine. Would like to see that perhaps mentioned in the docs under product like "Useful if you want to define different linking options per product. "
There was a problem hiding this comment.
@yonaskolb That's a good idea. I've added it in 9785749.
Sure! I'v added that in be92f16. |
|
Looks good! Thanks @simonbs! |
# Conflicts: # Tests/Fixtures/SPM/SPM.xcodeproj/project.pbxproj # Tests/Fixtures/SPM/project.yml
Adds support for specifying multiple products for when adding a package dependency to a target.
With this change dependencies that were previously written as
can now be written as
This makes it easier to add multiple products of a single package.