Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set error message for missing build targets in scheme #1040

Merged
merged 2 commits into from
Mar 31, 2021

Conversation

dalemyers
Copy link
Contributor

The current behavior means it just crashes due to trying to force unwrap
a nil optional.

Note: A build target shouldn't really be needed, but this is just a
quick fix to get things moving again.

The current behavior means it just crashes due to trying to force unwrap
a nil optional.

Note: A build target shouldn't really be needed, but this is just a
quick fix to get things moving again.
@freddi-kit
Copy link
Collaborator

Hi, @dalemyers. Thank you for your contribution! Looks good to me.
Could you add what you fix in CHANGELOG.md? According to this PR, you fixed the feature so please write in https://github.com/yonaskolb/XcodeGen/blob/master/CHANGELOG.md#fixed

FYI: https://github.com/yonaskolb/XcodeGen/blob/master/CONTRIBUTING.md#submitting-your-pr

@dalemyers
Copy link
Contributor Author

Done!

Copy link
Collaborator

@freddi-kit freddi-kit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Owner

@yonaskolb yonaskolb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dalemyers

@yonaskolb yonaskolb merged commit ff64a4a into yonaskolb:master Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants