WIP: kor backend - http server #354
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lidation has been added, token validation moved to a separate file
yonahd
reviewed
Sep 25, 2024
| } | ||
|
|
||
| // Validate list namespaces | ||
| func validateListNamespaces(next http.Handler) http.Handler { |
| api := router.PathPrefix("/api/v1").Subrouter() | ||
|
|
||
| router.HandleFunc("/healthcheck", healthCheckHandler).Methods("GET") | ||
| api.Handle("/configmaps", authMiddleware(validateListNamespaces(http.HandlerFunc(getUnusedConfigmaps)))).Methods("GET") |
There was a problem hiding this comment.
Since this will grow, maybe this should be in a create routes function
| RUN go build -o /go-service | ||
|
|
||
| # Use a smaller base image for the final container | ||
| FROM alpine:latest |
There was a problem hiding this comment.
use FROM scratch it will make the image significantly smaller
| @@ -0,0 +1,33 @@ | |||
| # Use an official Golang image as the build environment | |||
| FROM golang:1.22.2-alpine AS builder | |||
There was a problem hiding this comment.
Take a look at the kor dockerfile https://github.com/yonahd/kor/blob/main/Dockerfile
| making it easier to integrate into web services, dashboards, and automation pipelines. | ||
|
|
||
| ## Swagger | ||
| ```swag init``` |
There was a problem hiding this comment.
Is the swagger initialized by default in the docker?
| package main | ||
|
|
||
| import ( | ||
| "crypto/tls" |
There was a problem hiding this comment.
Please sort the imports as we do in kor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
Defines KOR HTTP server that uses the Gorilla Mux router, JWT authentication, and Swagger documentation
Functionality:
PR Checklist
GitHub Issue
Notes for your reviewers